Open
Conversation
|
E2E Tests 🚀 |
Contributor
|
Don't forget that this is how you test in CI: I ran against your PR and it looks good! For a refresher, here is what happens: So, its annoying but using the tag for pyrefly on your PR doesn't do anything. |
3 tasks
Updated the notebook diagnostics test to use the notebooksPositron fixture instead of the legacy notebooks fixture. Key changes: - Enable Positron notebooks in test settings - Use notebooksPositron.newNotebook() and kernel.select() - Replace typeInEditor with addCodeToCell - Use proper Positron notebooks content expectations - Enter edit mode before editing cell content This unskips the test and makes it work correctly with Positron notebooks. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request expands the test coverage for Python diagnostics in the LSP integration tests, aiming to catch potential issues and breakages in diagnostic functionality. It introduces several new test cases for common Python errors and edge cases, and prepares groundwork for future tests on QMD and Notebook files. Additionally, a minor documentation update clarifies a parameter name in the
Problemspage object (badgeCount).Expanded Python diagnostics test coverage:
lsp-diagnostics.test.tsto verify diagnostics for scenarios such as non-existent module imports, missing attributes, calling non-callables, incompatible assignments, wrong return types, list/dict element type mismatches, and type errors with indentation issues. These tests improve robustness and help detect pyrefly-related issues or delays..qmdand.ipynbfiles. These are placeholders for future diagnostic coverage.Test infrastructure improvement:
pathmodule inlsp-diagnostics.test.tsto support file path operations for future and existing tests.Documentation update:
problemCounttobadgeCountin theProblemspage object, making the expected badge count meaning more explicit.@:pyrefly @:web