fix: Add 'examples/airmass' to app_hard_wait#2172
Draft
karangattu wants to merge 3 commits intomainfrom
Draft
Conversation
Include "examples/airmass": 250 in app_hard_wait within tests/playwright/examples/example_apps.py to give the airmass example a 250ms hard wait. This change helps stabilize Playwright tests for the airmass example and reduce flakiness.
karangattu
changed the title
Adapt tests to updated DataFrame API and improve assertions. Replace positional/list set_sort calls with dicts specifying {col, desc} for clarity and to match the new API. Add import re and an assertion to verify the active tab value, and assert the df_type output matches the tab name via a regex. These changes make the tests more robust and aligned with the component API.
Make the Playwright navigation in the navset_hidden_kitchensink test more robust by importing Error and wrapping page.goto in a try/except. If a Playwright Error with message "interrupted by another navigation" occurs, the test retries page.goto once; other errors are re-raised. This reduces flakiness from concurrent navigation races.
Collaborator
Author
|
Moving it to draft stage to see if airmass examples still fail before merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include "examples/airmass": 250 in app_hard_wait within tests/playwright/examples/example_apps.py to give the airmass example a 250ms hard wait. This change helps stabilize Playwright tests for the airmass example and reduce flakiness.