(feat): Sync Streams #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ler logic to StreamingSyncImplementation.
simolus3
reviewed
Jan 20, 2026
simolus3
left a comment
simolus3
left a comment
There was a problem hiding this comment.
Thanks for taking a look at sync streams 🚀 I have a few high-level / API design comments from a quick look, but please treat them as optional since I'm not that familiar with the dotnet SDK.
…ia a factory. Scaffolding A MockRemote test.
simolus3
reviewed
Jan 28, 2026
simolus3
left a comment
simolus3
left a comment
There was a problem hiding this comment.
This looks good to me from a high-level perspective (since I don't know C# that much).
LucDeCaf
reviewed
Jan 28, 2026
Contributor
LucDeCaf
left a comment
LucDeCaf
left a comment
There was a problem hiding this comment.
Happy overall, might be able to improve the user-facing API a little bit.
Chriztiaan
force-pushed
the
feat/sync-streams
branch
from
361396c to
9d9bd22
Compare
LucDeCaf
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for sync streams, based on reference implementations from other SDKs.
Minor changes were made to the API to support mocking of the remote, this allows new possibilities with mocking the backend when testing.