Update attachment package #735
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ed32db1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
stevensJourney
left a comment
stevensJourney
left a comment
There was a problem hiding this comment.
This looks like a good improvement so far. I've added some comments for some items I spotted.
packages/attachments/src/storageAdapters/NodeFileSystemAdapter.ts
Outdated
Show resolved
Hide resolved
- Added `getAttachment` method to retrieve an attachment by ID in AttachmentContext. - Updated `upsertAttachment` to handle null values for optional fields. - Introduced `generateAttachmentId` method in AttachmentQueue for generating unique IDs. - Modified `watchActiveAttachments` to accept a throttle parameter. - Added `deleteFile` method to have attachment deletion. - Updated tests to cover new functionality and ensure reliability.
…ttachment sync operations - Added AttachmentErrorHandler interface to manage download, upload, and delete errors for attachments. - Updated AttachmentQueue and SyncingService to utilize the new error handler. - Enhanced tests to verify error handling behavior during attachment sync processes.
joshuabrink
force-pushed
the
attachment-package-refactor
branch
from
671e23a to
bea28d9
Compare
joshuabrink
force-pushed
the
attachment-package-refactor
branch
from
bea28d9 to
e42ae45
Compare
8 tasks
Collaborator
|
Note: it looks like the attachments tests are failing here. Other Node.js tests should no longer be flaky. Please fix these new attachment tests before proceeding. |
Chriztiaan
reviewed
Jan 20, 2026
Chriztiaan
reviewed
Jan 21, 2026
Chriztiaan
reviewed
Jan 21, 2026
Chriztiaan
previously approved these changes
Jan 21, 2026
Contributor
Chriztiaan
left a comment
Chriztiaan
left a comment
There was a problem hiding this comment.
I am happy with this, the new docs make it easier to follow and implement too.
joshuabrink
force-pushed
the
attachment-package-refactor
branch
from
9a22452 to
ea24510
Compare
joshuabrink
force-pushed
the
attachment-package-refactor
branch
from
ea24510 to
7adf99d
Compare
Chriztiaan
approved these changes
Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a port of the Swift, Dart and Kotlin attachment's API to the JS SDK.
This addresses the following issues #715 and #714 by adding the
meta_datacolumn to the table and persisting it in the attachments table.It is currently still a work-in-progress so there are a couple things that still needs to be done: