Add configs to disable unused APIs [full CI]#1000
Open
mkannwischer wants to merge 13 commits intomainfrom
Open
Add configs to disable unused APIs [full CI]#1000mkannwischer wants to merge 13 commits intomainfrom
mkannwischer wants to merge 13 commits intomainfrom
Conversation
Contributor
CBMC Results (ML-DSA-65)Full Results (176 proofs)
|
Contributor
CBMC Results (ML-DSA-44)
Full Results (176 proofs)
|
Contributor
CBMC Results (ML-DSA-87)
Full Results (176 proofs)
|
0e7f1ba to
6b89fae
Compare
6b89fae to
69d203c
Compare
| CFLAGS += -DMLD_CONFIG_USE_NATIVE_BACKEND_ARITH | ||
| CFLAGS += -DMLD_CONFIG_USE_NATIVE_BACKEND_FIPS202 | ||
|
|
||
| # Disabled API flags |
Contributor
There was a problem hiding this comment.
Why don't we use auto-generated configs here?
Contributor
There was a problem hiding this comment.
I'm not sure if this question was directed at me. The disabled_apis and disabled_apis_native tests were added as a separate commit by @mkannwischer.
Only one table is used for each parameter set, so add conditions to remove the unused table from non-shared builds. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude key generation when not needed, together with all internal functions not needed for signature creation or verification. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude signature creation when not needed, together with all internal functions not needed for key generation or signature verification. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude signature verification when not needed, together with all internal functions not needed for key generation or signature creation. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude code only used for signature creation or verification. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude code only used for key generation or verification. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude code only used for key generation or signature creation. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Make it possible to exclude the wrapper APIs if not needed and build only the internal API functions. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
69d203c to
54b3c74
Compare
When building with MLD_CONFIG_REDUCE_RAM and only verifying or with MLD_CONFIG_SERIAL_FIPS202_ONLY, Keccak-f1600x2/x4 is not used and can be skipped. Signed-off-by: Anders Sonmark <Anders.Sonmark@axis.com>
Add examples testing four disabled API combinations (keygen-only, sign-only, verify-only, sign+verify) across all three parameter sets. disabled_apis_native additionally enables native arithmetic and FIPS-202 backends. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
… APIs The PCT implementation internally calls crypto_sign_signature() and crypto_sign_verify(), so it is incompatible with MLD_CONFIG_NO_SIGN_API and MLD_CONFIG_NO_VERIFY_API. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
Match the AArch64 behavior and skip the native Keccak-f1600x4 backend when MLD_CONFIG_SERIAL_FIPS202_ONLY or MLD_CONFIG_REDUCE_RAM is set. Signed-off-by: Matthias J. Kannwischer <matthias@zerorisc.com>
54b3c74 to
ec9c236
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #960 by @flynd to run full CI.