Refactor keccak_squeezeblock_x4() to improve proof time.#1640
Open
rod-chapman wants to merge 1 commit intomainfrom
Open
Refactor keccak_squeezeblock_x4() to improve proof time.#1640rod-chapman wants to merge 1 commit intomainfrom
rod-chapman wants to merge 1 commit intomainfrom
Conversation
Removes pointer arithmetic in favour of an integer current_offset value. Simplifies loop invariant. Proof time on M1/macOS falls from 127s to 25s for all values of MLKEM_K. With gcc 14.2.0 on macOS, generated code at -O3 is identical to the original, so no performance impact expected. Signed-off-by: Rod Chapman <rodchap@amazon.com>
Contributor
CBMC Results (ML-KEM-768)Full Results (187 proofs)
|
Contributor
CBMC Results (ML-KEM-1024)Full Results (187 proofs)
|
Contributor
CBMC Results (ML-KEM-512)Full Results (187 proofs)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes pointer arithmetic in favour of an integer current_offset value. Simplifies loop invariant.
Proof time on M1/macOS falls from 127s to 25s for all values of MLKEM_K.
With gcc 14.2.0 on macOS, generated code at -O3 is identical to the original, so no performance impact expected.