Add package configuration#4
Open
RNKuhns wants to merge 3 commits intopredict-ably:mainfrom
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| default_value: Any | ||
| allowed_values: Optional[Union[Tuple[Any, ...], List[Any]]] | ||
|
|
||
| def _get_values(self, param: str) -> Tuple[Any, ...]: |
Check notice
Code scanning / CodeQL
Returning tuples with varying lengths
| else: | ||
| return (param_values,) | ||
|
|
||
| def get_allowed_values(self) -> Tuple[Any, ...]: |
Check notice
Code scanning / CodeQL
Returning tuples with varying lengths
| """ | ||
| return self._get_values("allowed_values") | ||
|
|
||
| def get_expected_type(self) -> Tuple[type, ...]: |
Check notice
Code scanning / CodeQL
Returning tuples with varying lengths
| dh.set_config(do_something_else=True) | ||
|
|
||
| with pytest.raises(TypeError): | ||
| dh.set_config(True) |
Check failure
Code scanning / CodeQL
Wrong number of arguments in a call
| def test_set_config_invalid_keyword_argument(): | ||
| """Test set_config behavior when invalid keyword argument passed.""" | ||
| with pytest.raises(TypeError): | ||
| dh.set_config(do_something_else=True) |
Check failure
Code scanning / CodeQL
Wrong name for an argument in a call
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement/fix? Explain your changes.
Does your contribution introduce a new dependency? If yes, which one?
What should a reviewer concentrate their feedback on?
Any other comments?
PR checklist
For all contributions
the PR topic is related to enhancement, CI/CD, maintenance, documentation, or a bug.
For code contributions