fix: x86_64 architecture detection for macOS in Bootstrap.sh#2640
Merged
nickclark2016 merged 1 commit intopremake:masterfrom Mar 13, 2026
Merged
fix: x86_64 architecture detection for macOS in Bootstrap.sh#2640nickclark2016 merged 1 commit intopremake:masterfrom
nickclark2016 merged 1 commit intopremake:masterfrom
Conversation
nickclark2016
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The section in
Bootstrap.shthat automatically detects the macOS architecture only checks forarm64and does not check forx86_64. As a result, whenPLATFORMis not specified on Intel-based Macs, the script falls back to the defaultx86defined inBootstrap.mak. However, with the toolchains commonly used on macOS today,x86can no longer be compiled successfully.How does this PR change Premake's behavior?
This change modifies the script’s behavior when
PLATFORMis not specified so that it correctly recognizesx64.Anything else we should know?
The error message reported when
x86compilation fails is not very intuitive.Did you check all the boxes?
closes #XXXXin comment to auto-close issue when PR is merged)You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!