Conversation
Fix `type qualifiers ignored on function return type`.
The gpgme_set_passphrase_cb function expects a function pointer of type gpgme_passphrase_cb_t. The gpgme_passphrase_cb_t typedef specifies a function that returns gpgme_error_t so return GPG_ERR_NO_ERROR instead of 0.
GDestroyNotify takes a void* and returns void. Wrap xmpp_stanza_release to get rid of the incompatible function type warning.
`name` of the struct `color_def` was not initialized but is also not needed in this function.
The `arg_description` field was forgotten in 034a985.
Let's initialize them with NULL to make the compiler happy.
g_strstr_len() actually returns a gchar* to the position. So it is not like in the case of strlen() where it returns the number of bytes.
Fixing a couple of -Wsign-compare warnings.
Explicitly cast the void pointer returned by g_hash_table_lookup to the expected function pointer signature. Make `-Wpedantic` happy.
Seems like in signal address.device_id is int32 for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup regarding compiler warnings.