Skip to content

Sound effects and Sound Music #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Nilokrtz wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Sound effects and Sound Music #78

Nilokrtz wants to merge 2 commits into from

Conversation

@Nilokrtz
Copy link
Collaborator

@Nilokrtz Nilokrtz commented Jun 23, 2025

Implementation Fuctions of sound Music and sound effect

Resolving issue #76 and #73

@Nilokrtz Nilokrtz self-assigned this Jun 23, 2025
@profpantoja profpantoja self-requested a review July 9, 2025 03:00
profpantoja
profpantoja requested changes Jul 9, 2025
View reviewed changes
Copy link
Owner

@profpantoja profpantoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alterações:

  1. Deve seguir o mesmo padrão do mediator (provavelmente) pois cada tecnologia lida com o som de forma diferente;
  2. Observar pois pode ser uma outra Interface para lidar com os métodos do som;
  3. Deve usar como base a branch main atual;
  4. Criar um pacote chamado sound dentro do pacote game;
  5. Mover a classe SoundManager para dentro dela.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@profpantoja profpantoja profpantoja requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@Nilokrtz Nilokrtz

@Manudrel Manudrel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Nilokrtz @profpantoja @Manudrel