DO NOT MERGE: Trying to debug TestContext_Verify#48
Conversation
mtrmac
force-pushed
the
debug
branch
4 times, most recently
from
eba207c to
763c478
Compare
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
OK the warning goes away after using a recent Go version. That doesn’t fix the |
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
@proglottis comparing the test results from 601ef89 and da702f4 , updating GnuPG fixes Not finding the root cause is unsatisfactory, but I’m also not very motivated to diagnose bugs in 7-year-old unmaintained software. |
The last release was 1.4.23 in Jun 2018; it's not very relevant in modern environments. More importantly, the unit tests have been consistently failing on macOS recently, and per proglottis#48 it seems that the underlying GnuPG does not provide the expected output, and updating GnuPG fixes that. We've been pinned to 1.x for ctx.SetCallback, but that feature now exists in 2.x as well, as long as callers opt in. So, do so. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
The log for 601ef89 contains two instances of That’s also gone with the newer GnuPG. |
|
For the record, I can reproduce both the test failure, and the |
… and, logging the status of gpgme’s |
1 participant
My recent pull requests show macOS failures in that function, while it seems to run reliably for me locally.