Merged
Conversation
wcpettus
requested changes
Feb 5, 2026
wcpettus
approved these changes
Mar 5, 2026
wcpettus
left a comment
wcpettus
left a comment
There was a problem hiding this comment.
Looks good now - all requested changes responded to.
(GitHub still claimed there was one outstanding, but I couldn't find anything... hopefully this clears that)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We implement yet another company specific service and endpoint.
For the chiller from Huber there is a set of three commands however one of the commands controls several values (get and set).
Therefore we implement the protocol from Huber.
The tool works nicely with our chiller and we can read: