feat: migrate univ2 to SwapQuoter#523
Open
kayibal wants to merge 7 commits into
Open
Conversation
Collaborator
dianacarvalho1
left a comment
dianacarvalho1
left a comment
There was a problem hiding this comment.
Thank you @kayibal ! Only have one suggestion
| tokens: &HashMap<Bytes, Token>, | ||
| _decoder_context: &DecoderContext, | ||
| ) -> Result<Self, Self::Error> { | ||
| let component = ProtocolComponent::<Arc<Token>>::new( |
Collaborator
There was a problem hiding this comment.
couldn't we pass the ProtocolComponent already from the decoder? I think we already know them at this time
Collaborator
Author
There was a problem hiding this comment.
We probably can, but I didn't want to break more interfaces right now.
Collaborator
There was a problem hiding this comment.
but this would be the time to break all the interfaces no? 👀
Removes generic usage from EkuboV3 & updates tycho-execution
kayibal
force-pushed
the
ah/migrate-univ2-swap-quoter
branch
from
19b6f78 to
4e0fe65
Compare
Two root causes on aarch64-apple-darwin: 1. conda GCC in PATH lacks __ARM_FEATURE_AES/__ARM_FEATURE_SHA2 macros that Apple clang defines unconditionally → force CC to clang 2. macOS 26 SDK's Metadata.h contains ObjC block pointer syntax pulled in transitively by aws-lc-sys jitterentropy → skip via include guard Switch reqwest to native-tls to avoid pulling in aws-lc-rs unnecessarily. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
component(d0, d1) maps to token0 (0x...000) and token1 (0x...001). token0 is WETH (18 dec) and token1 is USDC (6 dec), so the argument order should be component(18, 6), not component(6, 18). The swapped decimals caused spot_price / get_limits to return wrong values, failing the PoolTargetPrice test with "Target X < limit Y" where Y >> X. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
kayibal
force-pushed
the
ah/migrate-univ2-swap-quoter
branch
from
8b53552 to
a0e82b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A preview on how to migrate a protocol to the new trait.