feat: EventSubscriptionCoordinator for dual-path architecture #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prosdev
force-pushed
the
feat/event-subscription-coordinator
branch
2 times, most recently
from
35de94a to
3dec678
Compare
Add new streaming package with coordinator pattern:
- EventSubscriptionCoordinator: Manages Pub/Sub subscription lifecycle
- EventCoordinatorManager: Coordinates multiple subscriptions
- EventHandler Protocol: Interface for event processing
Features:
- Bridge sync Pub/Sub callbacks to async handlers
- Graceful start/stop with queue draining
- Prometheus metrics (reusing queue metrics with coordinator labels)
- Support for dual-path: real-time + batched processing
Example usage:
```python
# Real-time processing
realtime = EventSubscriptionCoordinator(
subscription="events-realtime",
handler=process_immediately,
)
# Batched archival
archive = EventSubscriptionCoordinator(
subscription="events-archive",
handler=event_loader.add,
)
manager = EventCoordinatorManager([realtime, archive])
await manager.start_all()
```
Tests:
- 4 new unit tests (all passing)
- All 242 tests passing
- Fixed missing pytest-asyncio dependency
Documentation:
- Full docstrings with examples
- README: Added dual-path architecture section
- README: Removed all Firestore references
- README: Updated roadmap with completed features
prosdev
force-pushed
the
feat/event-subscription-coordinator
branch
from
3dec678 to
96ada68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new abstraction to enable dual-path event processing (real-time + batched), laying the foundation for future profile building.
Changes
New Components
Features
Documentation
Tests
pytest-asynciodependencyExample Usage
What This Enables
Related
specs/015-stream-subscription-coordinator.mdnotes/projects/eventkit-impl/015-stream-subscription-coordinator.md