This repository was archived by the owner on May 16, 2025. It is now read-only.
Modularize detection checks#90
Merged
seanpmorgan merged 3 commits intoprotectai:mainfrom Jan 14, 2024
Merged
Conversation
4 tasks
dadc392 to
a7458d7
Compare
a7458d7 to
a13af9c
Compare
fc5a216 to
eb21ad9
Compare
eb21ad9 to
07a8d42
Compare
Merged
This was referenced Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the JS SDK to perform the detection checks in a modular manner. This will make it easier to add new checks in the future as well as to customize which checks run by default.
I want to highlight that this is a BREAKING change for the SDK and will be a breaking change to the API once the same changes are made to it. I believe this is an acceptable change because at least in open source GitHub, no one is using the parameters that I am removing. For this code search, the only result of note is a demo notebook in LangChain, and it's only the output that includes the fields I'm removing.
#91 updates files in
serveralong with a few others.Once #88 is merged, I'd be willing to update the Python SDK to use the modular check logic.
A few notes about the changes in this PR:
tacticOverridesparameter.Part of #13