Fix(run_synthesis.sh): fail if any command fails#119
Merged
phsauter merged 1 commit intopulp-platform:mainfrom Feb 24, 2026
Merged
Fix(run_synthesis.sh): fail if any command fails#119phsauter merged 1 commit intopulp-platform:mainfrom
phsauter merged 1 commit intopulp-platform:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
If yosys synthesis fails, the bash only passes on the exit command of the last command in the pipe chain, in this case, the result of the gawk command.
This means that even if yosys fails, the script will still exit with a return value of 0, which is unhelpful when it is invoked by another script/tool.
Solution
Set
set -o pipefail, which means that the script will return the exit status of the rightmost command that failed, or 0 if none failed.