Open
Conversation
bastelfreak
reviewed
Feb 23, 2024
manifests/config.pp
Outdated
| } | ||
|
|
||
| if !empty($programs) { | ||
| create_resources(haproxy::program, $programs) |
Collaborator
There was a problem hiding this comment.
Please don't use create_resources(), it's deprecated and we want to get rid of it. please iterate on $programs and call the defined resource for each element.
Author
There was a problem hiding this comment.
@bastelfreak Doesn't seem to be deprecated in stdlib v9.4.1 where can I find such deprecation note? Generally I'd try to avoid code repetition, this feels like a code smell. I've tried to replace it, but I'm not sure what you mean.
bastelfreak
reviewed
Feb 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support running programs executed by main haproxy process as described in docs. At least
haproxyversion2.0is required.Checklist
puppet apply)