(PA-6886) Add Digicert to Solaris images#859
Open
cthorn42 wants to merge 2 commits intopuppetlabs:mainfrom
Open
(PA-6886) Add Digicert to Solaris images#859cthorn42 wants to merge 2 commits intopuppetlabs:mainfrom
cthorn42 wants to merge 2 commits intopuppetlabs:mainfrom
Conversation
e-gris
reviewed
Aug 9, 2024
cthorn42
force-pushed
the
maint/main/PA-6886_add_digicert_for_solaris
branch
from
e8cd81b to
5122f7f
Compare
joshcooper
reviewed
Aug 12, 2024
cthorn42
force-pushed
the
maint/main/PA-6886_add_digicert_for_solaris
branch
from
5122f7f to
479be34
Compare
joshcooper
approved these changes
Aug 12, 2024
Collaborator
Author
Contributor
|
After merging this and releasing vanagon, please remember to revert this https://github.com/puppetlabs/ci-job-configs/pull/9643 |
joshcooper
reviewed
Aug 15, 2024
e-gris
approved these changes
Aug 15, 2024
cthorn42
force-pushed
the
maint/main/PA-6886_add_digicert_for_solaris
branch
from
39d4d47 to
e276fab
Compare
e-gris
suggested changes
Aug 28, 2024
Contributor
e-gris
left a comment
e-gris
left a comment
There was a problem hiding this comment.
- One minor CHANGELOG request
- Please squash commits
| This changelog adheres to [Keep a CHANGELOG](https://keepachangelog.com). | ||
|
|
||
| ## [Unreleased] | ||
| - Bump minimum ruby requirement to 2.7 |
Contributor
There was a problem hiding this comment.
Please created a '### Changed' section for this.
The DigiCertGlobalRootG2 is now used by Artifactory and the VMs we're using for Solaris don't contain that cert by default. We for sure update our images to include that, but until that is done we need to make sure to use it. Also, in our case the OpenSSL used on our Solaris VMs is ancient and doesn't support openssl-rehash, so we have to create the sim link ourself. Once we update our images this commit can be reverted.
removed cops are provided by gems not explicitly installed they seem to be installed using the setup ruby action, but not when testing in a ruby docker image either way, they are covered by enabling newcops fix rubocop namespaces bump rubocop target ruby version fix tests that depend on docker command existing discovered when running test suite with ruby:3.2 image on docker (maint) Rubocop 1.65.1 Autocorrect fixes
cthorn42
force-pushed
the
maint/main/PA-6886_add_digicert_for_solaris
branch
from
ca258ac to
368dcd7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The DigiCertGlobalRootG2 is now used by Artifactory and the VMs we're using for Solaris don't contain that cert by default.
We for sure update our images to include that, but until that is done we need to make sure to use it.
Also, in our case the OpenSSL used on our Solaris VMs is ancient and doesn't support openssl-rehash, so we have to create the sim link ourself. Once we update our images this commit can be reverted.
Please add all notable changes to the "Unreleased" section of the CHANGELOG.