P4DEVOPS-11504: pass redis_reconnect_attempts to API redis connection#701
Open
P4DEVOPS-11504: pass redis_reconnect_attempts to API redis connection#701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On startup,
vmpooler-devrepeatedly hitsRedis::CannotConnectErrorbecause the API thread creates its Redis connection withoutredis_reconnect_attempts:The manager thread correctly passed the configured value, which is the exponential-backoff array
[0, 0.25, 0.5, 1, 2, 4, 8, 16, 32, 64, 128, 256, 512]. The API did not, so its 10 instant retries exhausted before Redis was ready.This only surfaces in dev because dev Redis has very limited resources (13m CPU / 96Mi memory) and takes longer to start, while prod Redis is already warm on restart.
Fix
Pass
redis_reconnect_attemptstoVmpooler.new_redisin the API thread, consistent with the manager.