fix defunct processes and deregister server before it stops#536
Open
chaosue wants to merge 1 commit intopydio:mainfrom
Open
fix defunct processes and deregister server before it stops#536chaosue wants to merge 1 commit intopydio:mainfrom
chaosue wants to merge 1 commit intopydio:mainfrom
Conversation
Member
|
needs more attention, we will dig that one, seems to have side-effect (require multiple Ctrl+C sometimes). |
|
chaos seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as shown above, after stopping the master cells process, there might be some sub processes left defunct in random.
two points in cells may lead to this problem.
Stopmethod in main routine does not wait theStartAndWaitmethod to complete waiting its sub process.gateway.dataplugin , which uses the minio package, does not fork, so it still serves in the main process, while the minio's exit function will directly end the main process when stopping the pulgin. However the minio's exit function cannot be customized, so there's no way to tweak this behaviour from the minio side at present. Only the forking way may resolve it.so whether there will be defunct processes depends on who (the main process and its sub processes) exits first in random.
another point, shall we deregister the server to notify the client-ends in advance before stopping the server to prevent unexpected future requests.