poc: bundle js assets on build time#850
Draft
cristianoliveira wants to merge 3 commits intov5-devfrom
Draft
Conversation
cristianoliveira
force-pushed
the
poc/fe-build
branch
from
7ac48c1 to
96f40b2
Compare
This commit changes the bundle validation script to dynamically find and validate all plugins with webpack.config.js files instead of only checking the meta.user plugin. Detailed Changes: - Implementation: - Changed validate-bundles.sh to find all plugins with webpack.config.js files and validate each bundle. - Changed the minimum bundle size check from 1KB to 50KB. - Added summary statistics for plugins and bundles validated, passed, failed, and skipped. - Changed the error messages and rebuild instructions to list each plugin that needs rebuilding. - Development Experience: - Changed the script to provide more detailed output and better debugging information.
cristianoliveira
commented
Mar 2, 2026
| @@ -0,0 +1,283 @@ | |||
| #!/bin/bash | |||
Contributor
Author
There was a problem hiding this comment.
This script here might be a overkill but I wanted to be able to check and fail the build in case the minified js wasn't properly generated
cristianoliveira
commented
Mar 2, 2026
|
|
||
| ## Frontend Assets Building | ||
|
|
||
| build-frontend-assets: |
Contributor
Author
There was a problem hiding this comment.
Basically we would just need to add this step to run before the build in the Makefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small POC to see how hard would be to remove the minified js from git and generate it at build time