Skip to content

Conversation

@f-brinkmann
Copy link
Member

@f-brinkmann f-brinkmann commented Feb 8, 2026

This is a version of pyfar.signals.files.room_impulse_response() that still has the nois tail. I would like to add this for being used in a new pyrato example notebook showing how to estimate room acoustic parameters.

In a second step I would make a pull in pyfar to add a boolen parameter to pyfar.signals.files.room_impulse_response() to indicate wether or not to return the RIR with noise tail.

I thought about also adding the Matlab script for generating the data using the raw measurement. But that requires private files anyhow. So I opted to not do this.

@f-brinkmann f-brinkmann moved this from Backlog to Require review in Weekly Planning Feb 8, 2026
@f-brinkmann f-brinkmann added the enhancement New feature or request label Feb 8, 2026
@mberz
Copy link
Member

mberz commented Feb 10, 2026

As already mentioned I don't think this the best way to provide a noisy RIR for example notebooks.
The peak to noise ratio contained in the example file is not known from the wav file, which is not the best case when one wants to validate the results in an example and also not really flexible when one wants to play around with an example.
I think it makes a lot more sense to simply add noise to the RIR via code within the example.

See the old (but outdated example notebook of pyrato)
https://github.com/pyfar/pyrato/blob/main/examples/energy_decay_curves_and_reverberation_time.ipynb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Require review

Development

Successfully merging this pull request may close these issues.

2 participants