fix: avoid crash in dunder lookup with a non-class metaclass#3070
Open
Pierre-Sassoulas wants to merge 1 commit into
Open
fix: avoid crash in dunder lookup with a non-class metaclass#3070Pierre-Sassoulas wants to merge 1 commit into
Pierre-Sassoulas wants to merge 1 commit into
Conversation
``_class_lookup`` passed the result of ``ClassDef.metaclass()`` straight to ``_lookup_in_mro``, which calls ``ancestors()``. When a class declares an explicit metaclass that infers to a non-class node (e.g. a function), that node has no MRO and the lookup crashed with an ``AttributeError``. Treat such a metaclass as if no special method was found. Closes #3063
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3070 +/- ##
=======================================
Coverage 93.52% 93.52%
=======================================
Files 92 92
Lines 11329 11329
=======================================
Hits 10596 10596
Misses 733 733
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
_class_lookuppassed the result ofClassDef.metaclass()straight to_lookup_in_mro, which callsancestors(). When a class declares an explicit metaclass that infers to a non-class node (e.g. a function), that node has no MRO and the lookup crashed with anAttributeError. Treat such a metaclass as if no special method was found.Closes #3063