fix: avoid TypeError crash for functional Enum with non-string member#3072
Draft
Pierre-Sassoulas wants to merge 1 commit into
Draft
fix: avoid TypeError crash for functional Enum with non-string member#3072Pierre-Sassoulas wants to merge 1 commit into
Pierre-Sassoulas wants to merge 1 commit into
Conversation
``infer_func_form`` filters whitespace out of member names with
``" " not in attr``, assuming every attribute is a string. A functional
``Enum`` call such as ``Enum("e", (1,))`` yields an integer member name,
making that check raise ``TypeError``. Such a definition is invalid, so
raise ``UseInferenceDefault`` and let inference fall back instead.
Closes #3068
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3072 +/- ##
=======================================
Coverage 93.52% 93.53%
=======================================
Files 92 92
Lines 11329 11331 +2
=======================================
+ Hits 10596 10598 +2
Misses 733 733
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
infer_func_formfilters whitespace out of member names with" " not in attr, assuming every attribute is a string. A functionalEnumcall such asEnum("e", (1,))yields an integer member name, making that check raiseTypeError. Such a definition is invalid, so raiseUseInferenceDefaultand let inference fall back instead.Closes #3068