fix: handle non-callable __class_getitem__ in ClassDef.getitem#3073
Open
Pierre-Sassoulas wants to merge 1 commit into
Open
fix: handle non-callable __class_getitem__ in ClassDef.getitem#3073Pierre-Sassoulas wants to merge 1 commit into
Pierre-Sassoulas wants to merge 1 commit into
Conversation
When subscripting a class, ``getitem`` falls back to ``__class_getitem__`` and assumes the resolved node is callable. If it instead resolves to a non-callable node such as an ``AssignName`` (e.g. ``dataclasses.Field``, whose ``__class_getitem__`` is assigned rather than ``def``-ined), calling ``infer_call_result`` raised an ``AttributeError`` that escaped inference. Raise ``AstroidTypeError`` instead, matching ``getitem``'s documented contract. Closes #3064
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3073 +/- ##
==========================================
- Coverage 93.52% 93.52% -0.01%
==========================================
Files 92 92
Lines 11329 11331 +2
==========================================
+ Hits 10596 10597 +1
- Misses 733 734 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
When subscripting a class,
getitemfalls back to__class_getitem__and assumes the resolved node is callable. If it instead resolves to a non-callable node such as anAssignName(e.g.dataclasses.Field, whose__class_getitem__is assigned rather thandef-ined), callinginfer_call_resultraised anAttributeErrorthat escaped inference. RaiseAstroidTypeErrorinstead, matchinggetitem's documented contract.Closes #3064