fix: avoid InferenceError crash in slots() for annotation-only __slots__#3074
Open
Pierre-Sassoulas wants to merge 1 commit into
Open
fix: avoid InferenceError crash in slots() for annotation-only __slots__#3074Pierre-Sassoulas wants to merge 1 commit into
Pierre-Sassoulas wants to merge 1 commit into
Conversation
``_islots`` checks for ``__slots__`` in ``locals`` and then infers it via ``igetattr``. When ``__slots__`` is declared as a bare annotation with no value (e.g. ``__slots__: None``), it is present in ``locals`` but cannot be inferred, so ``igetattr`` raised an ``InferenceError`` that escaped ``slots()``. Treat such a ``__slots__`` as not inferable and return None. Closes #3067
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3074 +/- ##
=======================================
Coverage 93.52% 93.53%
=======================================
Files 92 92
Lines 11329 11333 +4
=======================================
+ Hits 10596 10600 +4
Misses 733 733
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Changes
Description
_islotschecks for__slots__inlocalsand then infers it viaigetattr. When__slots__is declared as a bare annotation with no value (e.g.__slots__: None), it is present inlocalsbut cannot be inferred, soigetattrraised anInferenceErrorthat escapedslots(). Treat such a__slots__as not inferable and return None.Closes #3067