Skip to content

Conversation

@MrWaloo
Copy link
Contributor

@MrWaloo MrWaloo commented Jan 29, 2026

Some corrections according to the code

@MrWaloo
Copy link
Contributor Author

MrWaloo commented Jan 30, 2026

I understand your both remarks, but it is programmed with offset_address in the code. There are no mention of offset_* anywhere in the existing code. Even the test case is with offset_address (class TestSimDevice).

offset_address: tuple[int, int, int, int] | None = None

I just wanted to help to align the code and the docstrings/comments.

Copy link
Collaborator

@janiversen janiversen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I currently have another version active.

LGTM, Thanks.

@janiversen janiversen merged commit 5ca5fa2 into pymodbus-dev:dev Jan 30, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants