Conversation
- Replace INI config with YAML format - Embed all config data (blocked sites, URLs, shortcuts, headers, IPs) directly in YAML - Remove separate .txt and .json config files - Update code to use embedded config data - Clean up unused imports and old code - Update tests for new config structure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
When calling
server_socket.getpeername(), the code assumes the returned value is always a 2-element tuple(host, port).However, with IPv6 connections, the method returns a 4-element tuple
(host, port, flowinfo, scopeid), which causes unpacking errors such as:This breaks the application when handling IPv6 requests.
Issue Number: #20
What is the new behavior?
getpeername()hostandportin a safe and version-agnostic wayOther information