Skip to content

Update Invalid Name Checker Tests#1338

Merged
david-yz-liu merged 3 commits into
pyta-uoft:masterfrom
a1-su:invalid-name-checker-tests
May 13, 2026
Merged

Update Invalid Name Checker Tests#1338
david-yz-liu merged 3 commits into
pyta-uoft:masterfrom
a1-su:invalid-name-checker-tests

Conversation

@a1-su
Copy link
Copy Markdown
Contributor

@a1-su a1-su commented May 12, 2026

Proposed Changes

This updates the test coverage for the invalid_name_checker.py file. More specifically, it adds coverage for the following cases:

  • Ignoring a method that overrides an inherited method
  • Assignment to a Union or TypeAlias
  • Assignment in a tuple of a type variable or type alias
  • Aliasing of a class definition
  • Redefining an import with a variable
  • Constant annotation using Final outside a class

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests) X
📚 Documentation update (change that only updates documentation)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • I have updated the project Changelog (this is required for all changes).
  • If this is my first contribution, I have added myself to the list of contributors.

After opening your pull request:

  • I have verified that the CI tests have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

I assumed that it wasn't a priority to add coverage to legacy uses of TypeAlias, but if this is something that should also be covered, feel free to let me know.

image

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 12, 2026

Coverage Report for CI Build 25823378027

Coverage increased (+0.5%) to 90.539%

Details

  • Coverage increased (+0.5%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3879
Covered Lines: 3512
Line Coverage: 90.54%
Coverage Strength: 17.57 hits per line

💛 - Coveralls

@a1-su a1-su requested a review from david-yz-liu May 12, 2026 09:24
Copy link
Copy Markdown
Contributor

@david-yz-liu david-yz-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, @a1-su!

@david-yz-liu david-yz-liu merged commit 6ef78a0 into pyta-uoft:master May 13, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants