Skip to content

Upload results XML for warning stable builds #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 1 commit into from
Jun 17, 2025
Merged

Upload results XML for warning stable builds #608

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions master/custom/steps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,16 @@ class Test(BaseTest):
}

def evaluateCommand(self, cmd):
result = super().evaluateCommand(cmd)
if cmd.didFail():
self.setProperty("test_failed_to_build", True)
return super().evaluateCommand(cmd)
self.setProperty("want_xml_upload", True)
elif result == WARNINGS:
# For warnings, upload XML for main branch stable builders
tags = self.build.builder.config.tags
if 'stable' in tags and '3.x' in tags:
self.setProperty("want_xml_upload", True)
return result


class Clean(ShellCommand):
Expand Down Expand Up @@ -174,12 +181,12 @@ class UploadTestResults(steps.FileUpload):
flunkOnFailure = False
alwaysRun = True

def _has_the_build_failed(self, build):
return self.getProperty("test_failed_to_build")
def _want_xml_upload(self, build):
return self.getProperty("want_xml_upload")

def __init__(self, branch, filename=JUNIT_FILENAME):
super().__init__(
doStepIf=self._has_the_build_failed,
doStepIf=self._want_xml_upload,
workersrc=filename,
masterdest=util.Interpolate(
f"/data/www/buildbot/test-results/{branch}/%(prop:buildername)s/build_%(prop:buildnumber)s.xml"
Expand Down