gh-130425: Add "Did you mean [...]" suggestions for del obj.attr#136588
Merged
encukou merged 23 commits intopython:mainfrom Aug 22, 2025
Merged
gh-130425: Add "Did you mean [...]" suggestions for del obj.attr#136588encukou merged 23 commits intopython:mainfrom
del obj.attr#136588encukou merged 23 commits intopython:mainfrom
Conversation
picnixz
reviewed
Jul 12, 2025
picnixz
changed the title
del obj.attr
picnixz
reviewed
Jul 12, 2025
Misc/NEWS.d/next/Core_and_Builtins/2025-02-22-01-23-23.gh-issue-130425.x5SNQ8.rst
Show resolved
Hide resolved
picnixz
reviewed
Jul 12, 2025
Member
|
@Pranjal095 Please mark comments as Resolved when you are finished with them, it helps keep the PR organized. |
picnixz
reviewed
Jul 14, 2025
picnixz
reviewed
Aug 2, 2025
This allows moving test_suggestions_with_method_call back to test_getattr_suggestions_underscored, so that delattr is tested for these as well.
Member
|
I noticed that some of the setattr tests don't run for delattr, but could. See Pranjal095#1 |
Delattr suggestions re
Contributor
Author
|
Thanks a lot for catching this! I hadn’t noticed the issue myself, and I’m very happy to have merged the changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request replaces the earlier PR #130799 (now closed) and carries over that set of commits, preserving original authorship and history. An extra commit has been included to address a linting issue that was present in the previous version.
Issue: #130425