Skip to content

gh-140312: Set lltrace on JIT debug builds#140313

Merged
Fidget-Spinner merged 2 commits intopython:mainfrom
Fidget-Spinner:jit_fix_lltrace
Nov 1, 2025
Merged

gh-140312: Set lltrace on JIT debug builds#140313
Fidget-Spinner merged 2 commits intopython:mainfrom
Fidget-Spinner:jit_fix_lltrace

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Oct 18, 2025 •
edited by bedevere-app bot
Loading

This does not need a news as it's a purely internal change for our own debugging.

@bedevere-app bedevere-app bot mentioned this pull request Oct 18, 2025
Closed
savannahostrowski
savannahostrowski approved these changes Oct 19, 2025
View reviewed changes
Copy link
Member

@savannahostrowski savannahostrowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - backport as well?

markshannon
markshannon previously requested changes Oct 21, 2025
View reviewed changes
Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of macro tweaks to make the macro more function like.

@bedevere-app
Copy link

bedevere-app bot commented Oct 21, 2025

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@Fidget-Spinner @markshannon
Apply suggestions from code review
fd02365 
Co-authored-by: Mark Shannon <mark@hotpy.org>
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Nov 1, 2025

I have made the requested changes; please review again

@bedevere-app
Copy link

bedevere-app bot commented Nov 1, 2025

Thanks for making the requested changes!

@diegorusso, @savannahostrowski: please review the changes made to this pull request.

@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented Nov 1, 2025

I have two approvals and I've applied the changes requested by the latest review. Since this a minor change only affecting the experimental JIT, I will automerge.

@Fidget-Spinner Fidget-Spinner merged commit f701f98 into python:main Nov 1, 2025
71 of 74 checks passed
@Fidget-Spinner Fidget-Spinner deleted the jit_fix_lltrace branch November 1, 2025 16:23
@Fidget-Spinner Fidget-Spinner added the needs backport to 3.14 bugs and security fixes label Nov 1, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Nov 1, 2025

Thanks @Fidget-Spinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 1, 2025
@Fidget-Spinner @markshannon @miss-islington
pythongh-140312: Set lltrace on JIT debug builds (pythonGH-140313)
a9e8e6b 
(cherry picked from commit f701f98)

Co-authored-by: Ken Jin <kenjin@python.org>
Co-authored-by: Mark Shannon <mark@hotpy.org>
@bedevere-app
Copy link

bedevere-app bot commented Nov 1, 2025

GH-140887 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Nov 1, 2025
Fidget-Spinner added a commit that referenced this pull request Nov 1, 2025
@miss-islington @Fidget-Spinner @markshannon
[3.14] gh-140312: Set lltrace on JIT debug builds (GH-140313) (#140887)
ab1fdf3 
gh-140312: Set lltrace on JIT debug builds (GH-140313)
(cherry picked from commit f701f98)

Co-authored-by: Ken Jin <kenjin@python.org>
Co-authored-by: Mark Shannon <mark@hotpy.org>
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@Fidget-Spinner @markshannon @StanFromIreland
pythongh-140312: Set lltrace on JIT debug builds (pythonGH-140313)
683f119 
Co-authored-by: Mark Shannon <mark@hotpy.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher Awaiting requested review from brandtbucher brandtbucher is a code owner

@diegorusso diegorusso Awaiting requested review from diegorusso diegorusso is a code owner

@savannahostrowski savannahostrowski Awaiting requested review from savannahostrowski savannahostrowski is a code owner

@markshannon markshannon Awaiting requested review from markshannon

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Fidget-Spinner @diegorusso @savannahostrowski @markshannon