gh-140131: Fix REPL cursor position on Windows when module completion suggestion line hits console width by tanloong · Pull Request #140333 · python/cpython

tanloong · 2025-10-19T16:30:57Z

This skips handling the wrapping in self.__write_changed_line() when wlen(newline)==self.width, and simply updates self.posxy (explained in #140131 (comment)).

One thing that happens after the skip is that the cursor moves leftward by one character on Tab key:

WindowsTerminal_eDpHfMhTvA.mp4

As noted in this comment, "when writing to the final character on the line, the cursor location is effectively moved one element backwards." So, we account for this 1-character offset by setting the cursor column to a maximum of self.width-1.

WindowsTerminal_0fSumUhJoh.mp4

Issue: Import autocomplete in the REPL on Windows moves the text to the end of the next line #140131

… line hits console width

…ed px_pos variable" This reverts commit 742096d.

This reverts commit bb87563.

tanloong · 2026-02-09T15:48:18Z

@chris-eibl I've added tests for this.

tanloong · 2026-02-11T13:03:28Z

Thank you for the review! Added the second blurb.

chris-eibl

Lgtm. This is now ready for core dev review. Thank you for your contribution.

miss-islington-app · 2026-03-12T16:00:00Z

Thanks @tanloong for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

miss-islington-app · 2026-03-12T16:00:00Z

Thanks @tanloong for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington-app · 2026-03-12T16:00:01Z

Thanks @tanloong for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington-app · 2026-03-12T16:00:02Z

Thanks @tanloong for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

…letion suggestion line hits console width (pythonGH-140333) (cherry picked from commit e13f6dc) Co-authored-by: Tan Long <tanloong@foxmail.com>

miss-islington-app · 2026-03-12T16:00:09Z

Sorry, @tanloong and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e13f6dccd7a2f8df543a18c4a3ad92610dc087cb 3.13

bedevere-app · 2026-03-12T16:00:16Z

GH-145871 is a backport of this pull request to the 3.14 branch.

…letion suggestion line hits console width (pythonGH-140333) (cherry picked from commit e13f6dc) Co-authored-by: Tan Long <tanloong@foxmail.com>

miss-islington-app · 2026-03-12T16:00:44Z

Sorry @tanloong and @ambv, I had trouble completing the backport.
Please retry by removing and re-adding the "needs backport to 3.14" label.
Please backport backport using cherry_picker on the command line.

cherry_picker e13f6dccd7a2f8df543a18c4a3ad92610dc087cb 3.14

miss-islington-app · 2026-03-12T16:00:49Z

Sorry, @tanloong and @ambv, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker e13f6dccd7a2f8df543a18c4a3ad92610dc087cb 3.13

…le completion suggestion line hits console width (pythonGH-140333) (cherry picked from commit e13f6dc) Co-authored-by: Tan Long <tanloong@foxmail.com>

bedevere-app · 2026-03-12T16:02:39Z

GH-145872 is a backport of this pull request to the 3.13 branch.

…pletion suggestion line hits console width (GH-140333) (GH-145871) (cherry picked from commit e13f6dc) Co-authored-by: Tan Long <tanloong@foxmail.com>

…pletion suggestion line hits console width (GH-140333) (GH-145872) (cherry picked from commit e13f6dc) Co-authored-by: Tan Long <tanloong@foxmail.com>

bedevere-bot · 2026-03-12T21:10:34Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Ubuntu Shared 3.13 (tier-1) has failed when building commit 3ae8cc8.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1450/builds/1621) and take a look at the build logs.
Check if the failure is related to this commit (3ae8cc8) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1450/builds/1621

Failed tests:

test_pyrepl

Failed subtests:

test_repl_eio - test.test_pyrepl.test_unix_console.TestUnixConsoleEIOHandling.test_repl_eio

Summary of the results of the build (if available):

==

Click to see traceback logs

Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/subprocess.py", line 1140, in __del__
    _warn("subprocess %s is still running" % self.pid,
ResourceWarning: subprocess 3964108 is still running
Warning -- Unraisable exception
Exception ignored in: <_io.FileIO name=8 mode='rb' closefd=True>
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/unittest/case.py", line 650, in run
    with outcome.testPartExecutor(self):
ResourceWarning: unclosed file <_io.TextIOWrapper name=8 encoding='UTF-8'>
Warning -- Unraisable exception
Exception ignored in: <_io.FileIO name=10 mode='rb' closefd=True>
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/unittest/case.py", line 650, in run
    with outcome.testPartExecutor(self):
ResourceWarning: unclosed file <_io.TextIOWrapper name=10 encoding='UTF-8'>


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/subprocess.py", line 1140, in __del__
    _warn("subprocess %s is still running" % self.pid,
ResourceWarning: subprocess 3929058 is still running
Warning -- Unraisable exception
Exception ignored in: <_io.FileIO name=8 mode='rb' closefd=True>
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/unittest/case.py", line 650, in run
    with outcome.testPartExecutor(self):
ResourceWarning: unclosed file <_io.TextIOWrapper name=8 encoding='UTF-8'>
Warning -- Unraisable exception
Exception ignored in: <_io.FileIO name=10 mode='rb' closefd=True>
Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/unittest/case.py", line 650, in run
    with outcome.testPartExecutor(self):
ResourceWarning: unclosed file <_io.TextIOWrapper name=10 encoding='UTF-8'>


Traceback (most recent call last):
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/test/test_pyrepl/test_unix_console.py", line 415, in test_repl_eio
    _, err = proc.communicate(timeout=support.LONG_TIMEOUT)
             ~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/subprocess.py", line 1222, in communicate
    stdout, stderr = self._communicate(input, endtime, timeout)
                     ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/subprocess.py", line 2155, in _communicate
    self._check_timeout(endtime, orig_timeout, stdout, stderr)
    ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/subprocess.py", line 1269, in _check_timeout
    raise TimeoutExpired(
    ...<2 lines>...
            stderr=b''.join(stderr_seq) if stderr_seq else None)
subprocess.TimeoutExpired: Command '['/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/python', '-E', '-S', '/srv/buildbot/buildarea/3.13.bolen-ubuntu/build/Lib/test/test_pyrepl/eio_test_script.py']' timed out after 300.0 seconds

tanloong added 2 commits October 19, 2025 23:48

Fix REPL cursor position on Windows when module completion suggestion…

696a4ec

… line hits console width

blurb

fe459b8

bedevere-app bot mentioned this pull request Oct 19, 2025

Import autocomplete in the REPL on Windows moves the text to the end of the next line #140131

Open

tanloong added 7 commits October 20, 2025 22:13

Ensure storing the actual cursor column

ea21571

Add test

5c0593b

Remove irrelevant self.dch1 comment and unused px_pos variable

742096d

Revert unrelated change "Remove irrelevant self.dch1 comment and unus…

3c3d0aa

…ed px_pos variable" This reverts commit 742096d.

Merge branch 'main' into fix-repl-cursor-pos-windows-module-completion

939cb99

Remove unused import

4503176

Remove another unused import

1dc243b

tanloong marked this pull request as ready for review October 20, 2025 14:32

tanloong requested review from ambv, lysnikolaou and pablogsal as code owners October 20, 2025 14:32

bedevere-app bot added the awaiting review label Oct 20, 2025

tanloong marked this pull request as draft October 20, 2025 15:35

bedevere-app bot removed the awaiting review label Oct 20, 2025

tanloong added 3 commits October 20, 2025 23:49

Current fix breaks other tests, revert all changes

53b1314

Write newline to let wrapping take effect

f776e93

Add test

bb87563

tanloong marked this pull request as ready for review October 25, 2025 16:22

bedevere-app bot added the awaiting review label Oct 25, 2025

tanloong added 2 commits November 13, 2025 00:57

skip wrapping

89e4620

Revert "Add test"

210337b

This reverts commit bb87563.

chris-eibl mentioned this pull request Feb 8, 2026

gh-144259: Fix Windows EOL wrap by syncing real console cursor #144297

Closed

tanloong added 2 commits February 9, 2026 23:12

Add tests

1f993dc

Rename tests

1b39d22

Merge branch 'main' into fix-repl-cursor-pos-windows-module-completion

bfe86e5

chris-eibl self-requested a review February 10, 2026 18:48

Add second blurb

610eebc

chris-eibl approved these changes Feb 11, 2026

View reviewed changes

bedevere-app bot added awaiting core review and removed awaiting review labels Feb 11, 2026

stonebig mentioned this pull request Feb 14, 2026

Release 2026-01 follow-up winpython/winpython#1903

Open

4 tasks

ambv merged commit e13f6dc into python:main Mar 12, 2026
60 checks passed

bedevere-app bot removed the awaiting core review label Mar 12, 2026

ambv added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Mar 12, 2026

miss-islington-app bot assigned ambv Mar 12, 2026

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Mar 12, 2026

bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 12, 2026

Uh oh!

Conversation

tanloong commented Oct 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tanloong commented Feb 9, 2026

Uh oh!

tanloong commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chris-eibl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented Mar 12, 2026

Uh oh!

miss-islington-app bot commented Mar 12, 2026

Uh oh!

miss-islington-app bot commented Mar 12, 2026

Uh oh!

miss-islington-app bot commented Mar 12, 2026

Uh oh!

miss-islington-app bot commented Mar 12, 2026

Uh oh!

bedevere-app bot commented Mar 12, 2026

Uh oh!

miss-islington-app bot commented Mar 12, 2026

Uh oh!

miss-islington-app bot commented Mar 12, 2026

Uh oh!

bedevere-app bot commented Mar 12, 2026

Uh oh!

bedevere-bot commented Mar 12, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tanloong commented Oct 19, 2025 •

edited

Loading

tanloong commented Feb 11, 2026 •

edited

Loading