gh-143807: Limit executor growth#143814
Open
Fidget-Spinner wants to merge 2 commits intopython:mainfrom
Open
Conversation
Fidget-Spinner
changed the title
Member
|
Hmmm, can we confirm that this fixes the assertion failure on @devdanzin's system then at least, since this could at least be repro'd there? |
Member
|
I'll be able to test in about 6 hours. |
Member
|
Sorry about the delay, had to bisect it not reproducing on HEAD. e370c8d has made it stop aborting: Does that make sense? Applying the patch (edit: and running the MRE) leads to a segfault (with or without ASan), can you reproduce this? ASan output: Backtrace: Output of running with |
Member
Author
|
Thanks @devdanzin. The backtrace looks like the original repro for that other issue that you said fixed it thougj, so thats strange In any case, this is an actual logic bug we should fix. So even if it doesnt manifest for us we should fix it. |
markshannon
reviewed
Feb 2, 2026
| } | ||
| assert(size <= capacity); | ||
| if (size == capacity) { | ||
| if (capacity * 2 >= MAX_EXECUTORS_SIZE) { |
Member
There was a problem hiding this comment.
This would be easier to follow if we did the test on new_capacity below:
if (new_capacity >= MAX_EXECUTORS_SIZE) {
return -1;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No unit test, because the repro provided doesn't repro on my system.
The requirement is there can only be 255 executors in a single code object, as the executor index is bounded by
oparg, whch is aint8_t.size < MAX_EXECUTORS_SIZEfailed inget_index_for_executor#143807