Refactor PyFile_GetLine: reduce duplicated condition logic#145796
Closed
tryuzr wants to merge 1 commit intopython:mainfrom
Closed
Refactor PyFile_GetLine: reduce duplicated condition logic#145796tryuzr wants to merge 1 commit intopython:mainfrom
tryuzr wants to merge 1 commit intopython:mainfrom
Conversation
Consolidated repeated conditions `n < 0 && result != NULL` into a single check and handled the result type using PyBytes_Check and PyUnicode_Check inside the block. This reduces duplication and improves code readability while keeping the original behavior unchanged.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
|
This is churn IMO. |
StanFromIreland
added
pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consolidated repeated conditions
n < 0 && result != NULLinto a single check and handled the result type using PyBytes_Check and PyUnicode_Check inside the block.This reduces duplication and improves code readability while keeping the original behavior unchanged.