Imaplib: fix append args types
#15187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docstring for append method says: ``` All args except `message' can be None. ``` [v3.0](https://github.com/python/cpython/blob/v3.0/Lib/imaplib.py#L318) [v3.14](https://github.com/python/cpython/blob/v3.14.0/Lib/imaplib.py#L485) The body of the method performs truthiness checks on each argument except `message` and sets them to an appropriate value or None anyway.
The append method passes `date_time` (after None check) immediately into the `Time2Internaldate` function, so it seems reasonable to have append accept anything that `Time2Internaldate` would accept.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #15183:
1.
appendmethod acceptsNonefor most argsDocstring for
appendmethod says:v3.0
v3.14
The body of the method performs truthiness checks on each argument
except
messageand sets them to an appropriate value orNoneanyway.2.
date_timearg toappendcan be a union of typesThe append method passes
date_timeimmediatelyinto the
Time2Internaldatefunction, so it seems reasonable to haveappendaccept anything thatTime2Internaldatewould accept.