Automated testing framework which will give us regression and coverage reports, meant to run in a GH Action and locally#84
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
r41k0u
commented
Apr 8, 2026
| import sys | ||
| from pathlib import Path | ||
|
|
||
| if sys.version_info >= (3, 11): |
Collaborator
Author
There was a problem hiding this comment.
Unnecessary, will always be >3.11
r41k0u
commented
Apr 8, 2026
| else: | ||
| import tomli as tomllib | ||
|
|
||
| from .bpf_test_case import BpfTestCase |
Collaborator
Author
There was a problem hiding this comment.
Should use full paths
r41k0u
commented
Apr 8, 2026
| CONFIG_FILE = TESTS_DIR / "test_config.toml" | ||
|
|
||
| VMLINUX_TEST_DIRS = {"passing_tests/vmlinux"} | ||
| VMLINUX_TEST_PREFIXES = { |
Collaborator
Author
There was a problem hiding this comment.
These var names don't make sense here. VMLINUX_TEST_DIRS_PASSING and VMLINUX_TEST_DIRS_FAILING, with a union for VMLINUX_TEST_DIRS should be the right one
r41k0u
commented
Apr 25, 2026
| text=True, | ||
| timeout=30, | ||
| ) | ||
| output = result.stdout + result.stderr |
Collaborator
Author
There was a problem hiding this comment.
maybe return a map with stdout and stderr keys?
Collaborator
Author
There was a problem hiding this comment.
better - use namedtuple
Collaborator
Author
|
we can cleanup |
r41k0u
commented
Apr 25, 2026
| text=True, | ||
| timeout=30, | ||
| ) | ||
| output = result.stdout + result.stderr |
Collaborator
Author
There was a problem hiding this comment.
better - use namedtuple
| test = [ | ||
| "pytest>=8.0", | ||
| "pytest-cov>=5.0", | ||
| "tomli>=2.0; python_version < '3.11'", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.