Fix comprehensive test#85
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR addresses pointer/value type mismatches when preparing arguments for BPF helper calls, especially around map helpers, by normalizing pointer depth before storing values into scratch temporaries.
Changes:
- Add pointer-depth normalization in
get_or_create_ptr_from_arg()(dereference when the evaluated expression yields a deeper pointer than the expected type). - Pass
expected_type=ir.IntType(64)into map helper argument preparation to drive consistent scratch-temp allocation. - Fix
deref_to_depth()to correctly track the current type while dereferencing, preventing invalid extra dereferences.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pythonbpf/helper/helper_utils.py | Adds pointer-depth normalization before storing evaluated helper arguments into scratch temporaries. |
| pythonbpf/helper/bpf_helper_handler.py | Provides expected_type to map helper arg preparation to avoid type mismatches during temp allocation/stores. |
| pythonbpf/expr/ir_ops.py | Fixes dereference loop type-tracking in deref_to_depth() to stop dereferencing once the type is non-pointer. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
r41k0u
force-pushed
the
fix/comprehensive-store-type-mismatch
branch
from
365746c to
d0f7a9d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.