[X86] Remove deprecated Int8DynamicActInt4WeightCPULayout#4037
Open
Xia-Weiwen wants to merge 2 commits intopytorch:mainfrom
Open
[X86] Remove deprecated Int8DynamicActInt4WeightCPULayout#4037Xia-Weiwen wants to merge 2 commits intopytorch:mainfrom
Xia-Weiwen wants to merge 2 commits intopytorch:mainfrom
Conversation
Remove the deprecated Int8DynamicActInt4WeightCPULayout and associated code from the old Config+Layout-based DA8W4 CPU path. This includes: - Delete torchao/prototype/dtypes/uintx/dyn_int8_act_int4_wei_cpu_layout.py - Delete torchao/dtypes/uintx/dyn_int8_act_int4_wei_cpu_layout.py (deprecated shim) - Remove exports from torchao/dtypes/__init__.py, torchao/dtypes/uintx/__init__.py, torchao/prototype/dtypes/__init__.py, torchao/prototype/dtypes/uintx/__init__.py - Remove dispatch registration from torchao/dtypes/affine_quantized_tensor_ops.py - Remove Int8DynamicActInt4WeightCPULayout entry from test_uintx_api_deprecation Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Xia-Weiwen
added
the
module: not user facing
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/4037
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 9a8cc11 with merge base 3d02561 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Xia-Weiwen
changed the title
Xia-Weiwen
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the deprecated Int8DynamicActInt4WeightCPULayout and its old Config+Layout-based DA8W4 CPU implementation path, along with the associated backward-compatibility import stub and dispatch registration.
Changes:
- Deleted the prototype DA8W4 CPU layout + TensorImpl implementation module.
- Removed the deprecated public exports/import stubs for
Int8DynamicActInt4WeightCPULayoutfromtorchao.dtypesandtorchao.prototype.dtypes. - Dropped the corresponding quantized-linear dispatch registration and updated the deprecation-warning import test.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| torchao/prototype/dtypes/uintx/dyn_int8_act_int4_wei_cpu_layout.py | Removes the deprecated prototype DA8W4 CPU layout + implementation. |
| torchao/prototype/dtypes/uintx/init.py | Stops exporting the removed layout from prototype uintx. |
| torchao/prototype/dtypes/init.py | Stops re-exporting the removed layout from prototype dtypes. |
| torchao/dtypes/uintx/dyn_int8_act_int4_wei_cpu_layout.py | Removes the backward-compatibility import stub module. |
| torchao/dtypes/uintx/init.py | Removes the deprecated layout export from non-prototype uintx. |
| torchao/dtypes/affine_quantized_tensor_ops.py | Removes DA8W4 CPU dispatch condition/impl registration from the AQT quantized-linear dispatch table. |
| torchao/dtypes/init.py | Removes the deprecated layout from top-level torchao.dtypes exports. |
| test/dtypes/test_uintx.py | Updates the deprecation import-warning test to no longer expect the removed API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the deprecated Int8DynamicActInt4WeightCPULayout and associated code from the old Config+Layout-based DA8W4 CPU path.