polling: support header_factory for per-poll token refresh#123
Merged
Conversation
Collaborator
Author
|
I'll be landing this current series of julee branches tomorrow (more doctrine + crud generation) so I can properly fix the rba e2e tests. |
absoludity
force-pushed
the
91-generated-CRUD-1
branch
from
8c1a0dd to
1ed5f91
Compare
HttpPollerService accepts an optional header_factory callable that is invoked on every poll_endpoint() call. The returned headers are merged over any static headers in PollingConfig.connection_params, with factory headers taking precedence. This allows consumers to supply a fresh OAuth2 token on each poll without storing the token (or any callable) in PollingConfig, which Temporal serialises as JSON and cannot carry callables.
absoludity
force-pushed
the
53-polling-token-refresh
branch
from
bc5a867 to
712657f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
header_factory: Callable[[], Awaitable[dict[str, str]]] | Noneparameter toHttpPollerService.__init__()poll_endpoint()call, if a factory is set it is called and its headers are merged over any static headers inPollingConfig.connection_params(factory wins on conflict)PollingConfigor thePollerServiceprotocol — fully backwards compatibleMotivation
Auth headers embedded in
PollingConfigat setup time expire with the OAuth2 token (15–60 min), causing all subsequent polls to fail with 401. SincePollingConfigis serialised as JSON by Temporal, it cannot carry a callable — the factory lives in the activity (worker process) instead.Fixes #53
Test plan
test_poll_endpoint_uses_header_factory_when_set— factory called, headers override configtest_poll_endpoint_skips_header_factory_when_none— no factory, config headers unchanged