Add unit tests for doctrine infrastructure#131
Draft
monkeypants wants to merge 1 commit into
Draft
Conversation
The doctrine tests depend on infrastructure with zero test coverage. A bug in any of these causes false negatives — violations pass silently. Add tests for the three critical modules: - core/parsers/ast.py: class extraction, import scanning, pipeline detection, module docstrings, edge cases (syntax errors, empty dirs, underscore-prefixed files). 33 tests. - core/infrastructure/repositories/introspection/bounded_context.py: BC discovery, reserved word filtering, nested solutions (contrib/), structural markers, caching, get-by-slug. 21 tests. - core/use_cases/generic_crud.py: Get/List/Create/Update base classes with a fake entity and in-memory repo. 10 tests. All tests are pure additions — no changes to production code. Fixes #130
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
core/parsers/ast.py— class extraction, import scanning, pipeline detection, edge casescore/infrastructure/repositories/introspection/bounded_context.py— BC discovery, filtering, nested solutions, cachingcore/use_cases/generic_crud.py— Get/List/Create/Update base classesContext
The doctrine test system depends on ~950 lines of parsing and discovery infrastructure that had zero test coverage. A bug in the AST parser or BC discovery means doctrine tests produce false negatives — violations pass silently. These tests exercise the public API without changing any production code.
Test plan
ruff checkcleanblack --checkcleanFixes #130