Skip to content

Package Build Fix for Release#21

Open
aqvining wants to merge 3 commits intomasterfrom
SiPS_5.0
Open

Package Build Fix for Release#21
aqvining wants to merge 3 commits intomasterfrom
SiPS_5.0

Conversation

@aqvining
Copy link
Copy Markdown
Collaborator

@aqvining aqvining commented Mar 9, 2026

The new toml system in nbdev did not, by default, set the include field such that nested modules get installed when installing from the remote with pip. Update should fix this.

@aqvining aqvining requested a review from gorkamunoz March 9, 2026 11:22
@gorkamunoz
Copy link
Copy Markdown
Collaborator

Hi @aqvining I don't understand why the new include is needed, what is specifically not being installed? As far as I can test, without this new include I can still import e.g. from projective_simulation.agents.core import Abstract_Agent. What do you refer as nested modules?

@aqvining
Copy link
Copy Markdown
Collaborator Author

aqvining commented Mar 23, 2026

Hi @gorkamunoz ,

I am trying to make it so that I can include the projective simulation version number in the requirements of an analysis repository, such that somebody trying to reproduce the analysis only has to run

pip install -r requirements.text

to build the proper environment. The requirement.txt includes "projective_simulation @ git+https://github.com/qic-ibk/projective_simulation.git@v0.1.0"

Currently, when I try to do this, it installs modules that are directly included in the projective_simulation folder (including agents.py and state_estimators.py, which I think are artifacts and can be removed) but not anything that is in a subfolder (e.g. agents//core.py. According to my research, the proposed change will fix this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants