feat: save values on quit#14
Merged
Merged
Conversation
askoura
commented
Jan 23, 2026
| @@ -517,6 +535,10 @@ class QlarrWebView | |||
| } | |||
| } | |||
|
|
|||
| fun saveProgressBeforeQuit() { | |||
askoura
commented
Jan 23, 2026
| navigationDirection = NavigationDirection.Resume, | ||
| ), | ||
| @JavascriptInterface | ||
| fun autoSaveValues(valuesToSave: String) { |
bepo00
reviewed
Jan 25, 2026
| @@ -166,7 +166,8 @@ class SurveyActivity : ComponentActivity() { | |||
| Toast.LENGTH_SHORT, | |||
| ).show() | |||
| } else { | |||
| finish() | |||
| qlarrWebView?.saveProgressBeforeQuit() | |||
| // finish() | |||
Comment on lines
+359
to
+364
| fun quit() { | ||
| runOnUiThread { | ||
| Toast.makeText(this, getString(R.string.values_saved), Toast.LENGTH_SHORT).show() | ||
| } | ||
| finish() | ||
| } |
Collaborator
There was a problem hiding this comment.
It would be nice to cancel "Press back again to exit" if we already exit and at this point as otherwise this toast waits for few more seconds
Comment on lines
+179
to
+183
|
|
||
| override fun onError(error: Throwable) { | ||
| surveyActivity?.reportError(error) | ||
| } | ||
| }, |
Collaborator
There was a problem hiding this comment.
We should exit here too. Better to not save responses then to not be able to exit the survey at all
Collaborator
Author
There was a problem hiding this comment.
yes, amen... nice catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.