feat: Clear user on login#15
Merged
Merged
Conversation
added 2 commits
February 1, 2026 12:59
bepo00
requested changes
Feb 3, 2026
Comment on lines
-36
to
-40
| val isUrlValid = | ||
| _loginState.value.selection != EnvSelection.PRIVATE || isValidUrl(trimmedUrl) | ||
| if (_loginState.value.selection == EnvSelection.PRIVATE && isUrlValid) { | ||
| sessionManager.saveEnv(BackendEnvironment.Private(trimmedUrl)) | ||
| } |
Collaborator
There was a problem hiding this comment.
we dont saveEnv therefore we try to login with http://this-will-be-intercepted
Comment on lines
+36
to
+48
| private fun checkForPreviousSession() { | ||
| if (sessionManager.hasPreviousSession()) { | ||
| _loginState.update { | ||
| it.copy( | ||
| previousSession = PreviousSessionInfo( | ||
| userName = sessionManager.getPreviousUserName(), | ||
| environment = sessionManager.getPreviousEnv() | ||
| ), | ||
| showSessionConflictDialog = true | ||
| ) | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
this is triggered also immediatelly after logging out. Doesnt feel right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Claude code... but I own every line