Add --enable-metrics#290
Open
Qup42 wants to merge 3 commits into
Open
Conversation
Qup42
commented
May 7, 2026
Comment on lines
+16
to
+26
| def bool_type(val: str) -> bool: | ||
| if val in ["True", "true", "1", "on", "yes"]: | ||
| return True | ||
| elif val in ["False", "false", "0", "off", "no"]: | ||
| return False | ||
| else: | ||
| raise ArgumentTypeError( | ||
| f'"{val}" is not a valid boolean value. Use True/False, true/false, yes/no, 1/0 or on/off.' | ||
| ) | ||
|
|
||
|
|
Collaborator
Author
There was a problem hiding this comment.
This extra code is required so that option behaves as expected. PERSIST_UPDATES = false leads to updates being persisted because any non empty to string is coerced to True. This should probably be used for --persist-updates, --only-pso-and-pos-permutation, --use-patterns and --use-text-index.
Qup42
commented
May 7, 2026
| dependencies = [ "psutil", "termcolor", "argcomplete", "pyyaml", "rdflib", "requests-sse", "tqdm>=4.60.0" ] | ||
|
|
||
| [project.optional-dependencies] | ||
| dev = [ "ruff", "pre-commit" ] |
Collaborator
Author
There was a problem hiding this comment.
Unrelated to the core of this PR but still nice to have.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.