Add missing parameters for generating signature#48
Open
jiangzm wants to merge 2 commits into
Open
Conversation
Author
|
+ |
Collaborator
|
I found one risk worth addressing before merge:
Suggested improvements:
The direction of the fix makes sense overall. I mainly want to avoid a signing failure turning into a corrupted output file and make the new behavior easier for users to discover. |
Author
@edhongcy Thank you for your suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an inconsistency in how
qbuilduses the GPG keyring across different commands.The following commands already use the configured GPG keyring file
QDK_GPG_PUBKEYRING:--import-key--list-keys--verifyHowever, the following signing commands were still using the default GPG keyring:
--sign--add-signThis could cause signing and verification to use different keyrings, leading to unexpected signature issues.
Changes
--signand--add-signby adding:--no-default-keyring--keyring $QDK_GPG_PUBKEYRING--add-signfail fast if GPG fails to generate a valid${qpkg}.sig, preventing the command from continuing into the QPKG rewrite path with a missing or empty signature.qbuildhelp text and the Debian manpage to document that--signand--add-signdepend onQDK_GPG_PUBKEYRING.InstallToUbuntu.shuninstall cleanup to remove/bin/qpkg_encrypt.Result