Align onDeferredPurchaseCompleted param name with sandwich (purchaseResult)#64
Merged
Merged
Conversation
…esult) Sandwich-sdk renames the QonversionEventsListener supertype param from transaction to purchaseResult (qonversion/sandwich-sdk#319). Renaming the override here keeps the names matched so the Kotlin PARAMETER_NAME_CHANGED_ON_OVERRIDE warning does not appear once the sandwich dependency is bumped past 7.9.1. The payload is a QPurchaseResult map (status/entitlements/error/source), so the new name is also the accurate one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
SpertsyanKM
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One-line rename of the listener override param
transaction->purchaseResult, matching qonversion/sandwich-sdk#319 (merged). Without this, the next sandwich bump past 7.9.1 makes Kotlin emit the supertype param-name mismatch warning on every consumer build (the same class of warning reported in qonversion/react-native-sdk#439). react-native-sdk and flutter-sdk already usepurchaseResultin their overrides.No behavior change: the only call site is positional inside sandwich, and the event payload is a QPurchaseResult map, so the new name is also semantically correct.
🤖 Generated with Claude Code