Skip to content

Add PublishModels info Getter() & Add sizecopy to prevent the original size info from being modified#1060

Open
stjean2016 wants to merge 2 commits into
qor5:mainfrom
stjean2016:main
Open

Add PublishModels info Getter() & Add sizecopy to prevent the original size info from being modified#1060
stjean2016 wants to merge 2 commits into
qor5:mainfrom
stjean2016:main

Conversation

@stjean2016
Copy link
Copy Markdown

@stjean2016 stjean2016 commented Dec 22, 2025

Note

Add getters to publish.Builder for publish model maps and update thumbName to use a copied size to avoid in-place mutation.

  • publish:
    • Expose getters on Builder: GetVersionPublishModels(), GetNonVersionPublishModels(), GetListPublishModels() returning internal model maps.
  • media:
    • thumbName now copies size before base.SaleUpDown to avoid mutating the original; displays dimensions from the copy in media/media_box.go.

Written by Cursor Bugbot for commit 21373ec. This will update automatically on new commits. Configure here.

@theplant-ci
Copy link
Copy Markdown

Hi @stjean2016. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Dec 22, 2025

Here's the code health analysis summary for commits c0066dd..21373ec. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Go LogoGo✅ SuccessView Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants