Add PublishModels info Getter() & Add sizecopy to prevent the original size info from being modified#1060
Open
stjean2016 wants to merge 2 commits into
Open
Add PublishModels info Getter() & Add sizecopy to prevent the original size info from being modified#1060stjean2016 wants to merge 2 commits into
stjean2016 wants to merge 2 commits into
Conversation
|
Hi @stjean2016. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Here's the code health analysis summary for commits Analysis Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Add getters to
publish.Builderfor publish model maps and updatethumbNameto use a copied size to avoid in-place mutation.Builder:GetVersionPublishModels(),GetNonVersionPublishModels(),GetListPublishModels()returning internal model maps.thumbNamenow copiessizebeforebase.SaleUpDownto avoid mutating the original; displays dimensions from the copy inmedia/media_box.go.Written by Cursor Bugbot for commit 21373ec. This will update automatically on new commits. Configure here.