feat(pagebuilder): add FindContainerByName and GetRenderFunc public accessors#1072
Open
eideroliveira wants to merge 1 commit into
Open
feat(pagebuilder): add FindContainerByName and GetRenderFunc public accessors#1072eideroliveira wants to merge 1 commit into
eideroliveira wants to merge 1 commit into
Conversation
…ccessors FindContainerByName is the non-panicking variant of ContainerByName — it returns nil when no container with the given name is registered, making it safe for public-facing routes where a stale DB row may reference a container type that has since been removed. GetRenderFunc exposes the registered render function on ContainerBuilder so callers outside the pagebuilder (e.g. a public route rendering a page's containers) can dispatch rendering without duplicating the model-name to render-function mapping.
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go |  |
May 8, 2026 5:24p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two public accessor methods for
pagebuilder.BuilderandContainerBuilder:Builder.FindContainerByName(name)— non-panicking variant ofContainerByName. Returnsnilwhen no container with the given name is registered, making it safe for public-facing routes where a stale DB row may reference a container type that has since been removed.ContainerBuilder.GetRenderFunc()— exposes the registered render function so callers outside the pagebuilder (e.g. a public route rendering a page's containers) can dispatch rendering without duplicating the model-name → render-function mapping.Test plan
FindContainerByNamereturns the correct builder for registered namesFindContainerByNamereturns nil for unregistered names (no panic)GetRenderFuncreturns the function set viaRenderFunc()