chore(deps): upgrade qor5/x to moby-migrated commit, drop docker/docker#1076
Open
dorothyyzh wants to merge 2 commits into
Open
chore(deps): upgrade qor5/x to moby-migrated commit, drop docker/docker#1076dorothyyzh wants to merge 2 commits into
dorothyyzh wants to merge 2 commits into
Conversation
Upgrade qor5/x to ce22ad0a and testcontainers-go to v0.42.0. Resolves CVE-2026-33997 and CVE-2026-34040. Migrate all 15 test files from theplant/testenv to gormx.MustStartTestSuite. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go | May 13, 2026 1:10p.m. | Review ↗ |
Important
AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.
…eld validation gorm v1.31.1 (pulled in via qor5/x upgrade) rejects slice fields without a valid foreign key or Valuer/Scanner interface. Widgets is handled via AddTypeHanders so it should be excluded from GORM's schema parsing. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
iBakuman
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
github.com/qor5/x/v3to commitce22ad0a(moby-migrated), which replacesdocker/dockerwithmoby/moby/apitestcontainers-goto v0.42.0 andtestcontainers-go/modules/redisto v0.42.0github.com/theplant/testenvfrom go.modtestenv.New().DBEnable(true).SetUp()togormx.MustStartTestSuite(ctx)CVEs Resolved
Verification
docker/dockerremoved from go.mod; replaced bymoby/moby/api v1.54.1andmoby/moby/client v0.4.0go build ./...passes (excludingmedia/*which requires systemlibvips/pkg-config)go vetclean on all migrated packages🤖 Generated with Claude Code